GirderItemIdToVolume transform

girder / girder_worker

Distributed task execution engine with Girder integration, developed by Kitware

http://girder-worker.readthedocs.io/

Apache License 2.0

34 stars 30 forks source link

GirderItemIdToVolume transform #323

Closed zachmullen closed 6 years ago

kotfic commented 6 years ago

Other than the dir thing this all looks good to me, I'd like to see an integration test with an item and two files that makes sure both files are downloaded. You might want to make a test_item_with_files fixture

zachmullen commented 6 years ago

@kotfic my integration test is now succeeding, but a different one is failing, and I have no idea why, any thoughts?

kotfic commented 6 years ago

First guess is it has something to do with the test_multi_file_item fixture being set to function scope, but not cleaning up the item after the yield

zachmullen commented 6 years ago

All set. The extraneous changes on here are due to chance breakages in two upstream libraries where we always install the latest version: click and flake8.