search

girder / girder_worker

Distributed task execution engine with Girder integration, developed by Kitware
http://girder-worker.readthedocs.io/
Apache License 2.0
34 stars 30 forks source link

Fail to start if exception occurs during plugin load #361

Closed zachmullen closed 4 years ago

zachmullen commented 4 years ago

Fixes #360

@kotfic PTAL. I guess celery is doing some dark magic monkey patching of print and standard pipes...

zachmullen commented 4 years ago

Looks like a test was depending on the wrong behavior. I will try to fix it up later I guess.

zachmullen commented 4 years ago

I'm not convinced we should start up if there's an exception during load. Would anyone actually defend that feature?

kotfic commented 4 years ago

I think the intention was to allow multiple plugins to be installed and if one fails to not cripple the whole system. In reality though I think you're probably right, plugin failure should probably cause a full stop and loudly complain.

zachmullen commented 4 years ago

I've changed the scope of this, and it's ready for review. Namely, we now fail catastrophically if plugins fail to load, which is desirable behavior. Aside from that, I also removed the hacked-up extension registry capability. Now the entry point is the exclusive way to load plugins. This gave us the opportunity to remove a fair amount of code.

kotfic commented 4 years ago

Oh, this represents a somewhat big change (failing loudly i mean) will you cut a new minor version once this is in?

zachmullen commented 4 years ago

Yes, I plan to cut a release as soon as these two PRs are merged. Thanks!