search

girder / girder_worker

Distributed task execution engine with Girder integration, developed by Kitware
http://girder-worker.readthedocs.io/
Apache License 2.0
34 stars 30 forks source link

Pin celery version in requirements.in #369

Closed jjnesbitt closed 3 years ago

jjnesbitt commented 3 years ago

Currently, celery is listed without versioning:

https://github.com/girder/girder_worker/blob/a827fed4e9b559c8ada60485ace87d56bba88e4e/requirements.in#L2-L6

Since celery 5.0.0 has been released, I believe that is what's trying to be installed when running things like girder build, causing this error to be thrown:

ModuleNotFoundError: No module named 'celery.task'

This is causing failing builds downstream. I'm not sure if anything more would be needed besides pinning celery to a previous version (probably 4.4.7), or if that's even the correct approach. Manually specifying celery==4.4.7 in downstream projects which use girder worker seems to fix the build issues.

zachmullen commented 3 years ago

Yes, let's make a PR to pin celery<5 for now.