search

girder / large_image

Python modules to work with large multiresolution images.
http://girder.github.io/large_image/
Apache License 2.0
193 stars 43 forks source link

Test and upgrade to Numpy 1.10.4 #23

Closed brianhelba closed 8 years ago

brianhelba commented 8 years ago

Numpy 1.10.4 is now released on Conda. If it works, we should upgrade (requirements.txt and Travis build) to use it.

I have noticed some weird behavior with pylibtiff on a machine where Numpy 1.10.4 was installed, but I haven't been able to definitively blame it on Numpy 1.10.4 yet. If it turns out there is a problem, we need to affirmatively blacklist this version of Numpy and document this issue.

brianhelba commented 8 years ago

@manthey Can you take a look at this? It should be fast, and I'd like to ensure that this and https://github.com/DigitalSlideArchive/HistomicsTK are using the same Numpy.

manthey commented 8 years ago

I've been using numpy 1.10.4 on my machine all along, as I had a single instance of Girder with several plugins I was working on and one of them required it. What sort of weird behavior were you having?

brianhelba commented 8 years ago

I was getting segfaults somewhere inside the initial import libtiff. It's totally possible that this is unrelated to Numpy, but I had started to get the error after upgrading Numpy.

If 1.10.4 works for you, just go ahead and formally change requirements.txt and Travis.

manthey commented 8 years ago

Done in PR #24.