girder / slicer_cli_web

A Girder plugin for exposing slicer execution model's CLI modules over the web
Apache License 2.0
16 stars 17 forks source link

Move in front-end CLI widget generation code from HistomicsTK #5

Closed cdeepakroy closed 8 years ago

cdeepakroy commented 8 years ago

This issue involves moving the javascript code that generates the front-end widgets for slicer CLIs embedded in docker images from HistomicsTK to this repo so it can be used by other projects.

CC: @jbeezley, @manthey

jbeezley commented 8 years ago

Doing this would be a good opportunity to migrate to the webpack infrastructure coming in girder 2.0. Is there an immediate need for this in girder 1.x deployments, or can it wait for other plugins to transition to 2.0 as well?

cdeepakroy commented 8 years ago

@jbeezley When is girder 2.0 scheduled? Once this repo is complete, then we can advertise it to be used by other projects.

jbeezley commented 8 years ago

It's getting close. I think the major issue is that if I target this at 2.0, anybody who wants to use it will need to port to 2.0 as well. On the other hand, the migration will be necessary eventually anyway. If this is necessary within the next month (give or take), then we might consider targeting this for 1.x then porting to 2.0 later.

jcfr commented 8 years ago

anybody who wants to use it will need to port to 2.0 as well

If all current user are Kitware projects, targeting 2.0 is reasonable

we might consider targeting this for 1.x then porting to 2.0 later.

Otherwise this would also work.

dzenanz commented 8 years ago

@zachmullen @jbeezley PET/CT calibration project could benefit from this.

jbeezley commented 8 years ago

Okay, I think I'll go ahead and target 1.x for the moment, and we'll tackle 2.0 when it comes out.

jbeezley commented 8 years ago

Done in #15