search

girder / viime

https://viime.org
Apache License 2.0
8 stars 3 forks source link

Bugs on Edge browser #437

Open jeffbaumes opened 4 years ago

jeffbaumes commented 4 years ago

Seems to work ok on Chrome/FF.

I think Microsoft has some free VMs for testing out their browsers.

We may also want to see what happens on IE 11.

subdavis commented 4 years ago

I'll take a look at this today.

subdavis commented 4 years ago
subdavis commented 4 years ago

Up and down arrows do not appear next to these controls anywhere in the app

Capture4

subdavis commented 4 years ago

Select styling is wrong

Capture7

subdavis commented 4 years ago

Capture3

subdavis commented 4 years ago

Capture6

subdavis commented 4 years ago

Landing page scaling issues. cc @jtomeck

Capture

subdavis commented 4 years ago

Vue infinite scroll table becomes confused. This appears to be related to the uncommon browser behavior where scrolling "past" a page's end causes it to stretch past and snap back into alignment when you let go. I believe Safari does the same thing.

I think there are ways to prevent this "overscrolling" but I'm not sure. https://stackoverflow.com/questions/12046315/prevent-overscrolling-of-web-page

Capture2

jeffbaumes commented 4 years ago

With this many issues, @subdavis do you think it would be best to do browser detection and put a blocking warning on the front page if using IE/Edge saying it is not supported and to use Chrome/FF/Safari (we still need to check Safari)? Or @subdavis @sgratzl do you think these are resolvable in the next day or two?

We should fix the front page issues regardless if possible so I'd prioritize that.

subdavis commented 4 years ago

That's not an Edge issue after all. It just happens on odd window sizes. I'll take a stab at it.

EDIT: Just noticed from the screenshots that the masked image doesn't even work on Edge. CC @sgratzl -- https://caniuse.com/#feat=css-masks

Screenshot from 2019-11-12 11-14-06

That being said, I personally love the logo masked screenshot.

subdavis commented 4 years ago

@jeffbaumes yeah IMO a browser warning banner would be appropriate. I don't have any apple hardware so someone else will need to check Safari.

sgratzl commented 4 years ago

several of the issues are just features edge is not capable of

Up and down arrows do not appear next to these controls anywhere in the app

we use the native input[type=number] it depends on the browser how it renders (with arrows or not)

* PCA plot ellipse styling is broken

I assume Edge is not supporting https://www.w3.org/TR/SVGTiny12/painting.html#VectorEffectProperty

without it we have to change how to scale the ellipses (should be possible)

* Double scrollbars (this happens on every browser)

the outer is because of the left menu that needs more space. the inner because the plots have its own scrolling area to avoid that the header bar is scrolling. Thus kinda intentional

Select styling is wrong

seems like Edge is not capable of the advanced gradient

jeffbaumes commented 4 years ago

@subdavis could you work on a banner of some sort?