search

girishchandranc / autosarfactory

AutosarFactory is a python package which helps user to read/create/modify AUTOSAR standard arxml files.
MIT License
87 stars 28 forks source link

Small updates to UI (search type), update README.md and minor version… #5

Closed PopAdrian1981 closed 3 years ago

PopAdrian1981 commented 3 years ago

Hi Girish, Updated after review. Jpg was already removed since it was updated in README.md. Sure, tests would be best to have for each new feature. (But I am not so sure how a test for search would work, to actually prove something meaningful. Do you ?) I will think about adding some in the future.

girishchandranc commented 3 years ago

Hi Adi, All seems to be okay except for the seachnodes set in each of the search criteria.

Also, we should increment the version in setup.py. Could you please do that also.

Sure, tests would be best to have for each new feature. (But I am not so sure how a test for search would work, to actually prove something meaningful. Do you ?) I will think about adding some in the future. Yes, thats okay..

PopAdrian1981 commented 3 years ago

Updates performed