girishso
commented
11 years ago Thanks! I'm on vacation, will look into this as soon as I get back.
On 26-Oct-2013, at 8:11 am, Elthariel notifications@github.com wrote:
Hi,
This PR is first a way to start talking :) not yet a real PR. I'm unable to run your test suite, and i would enjoy some help :)
Except from that part, i don't think this PR should go to master branch, but it could be a good idea to open a rails4 branch on your side.
You can merge this Pull Request by running
git pull https://github.com/elthariel/rails-client-logger rails4 Or view, comment on, or merge it at:
https://github.com/girishso/rails-client-logger/pull/2
Commit Summary
Switched to a Coffee based implementation Adds rails 4 support. Switch client-side to coffee script. Bump version since these changes are incompatible. Adds coffeescript support in generator File Changes
A .gitkeep b/test/dummy/db/.gitkeep (0) M Gemfile.lock (127) M README.md (9) M app/controllers/rails_client_logger/rails_client_loggers_controller.rb (4)
M lib/generators/rails_client_logger/rails_client_logger_generator.rb (29) M lib/rails-client-logger/version.rb (2) M rails-client-logger.gemspec (7) M test/dummy/config/application.rb (2) M test/dummy/config/environments/test.rb (8) M test/functional/js_logger/js_loggers_controller_test.rb (2) D vendor/assets/javascripts/rails_client_logger.js (34) A vendor/assets/javascripts/rails_client_logger.js.coffee (15) Patch Links:https://github.com/girishso/rails-client-logger/pull/2.patch https://github.com/girishso/rails-client-logger/pull/2.diff
ryoqun
elthariel
Hi,
This PR is first a way to start talking :) not yet a real PR. I'm unable to run your test suite, and i would enjoy some help :)
Except from that part, i don't think this PR should go to master branch, but it could be a good idea to open a rails4 branch on your side.