r-universe build failing on vignette

girke-lab / ChemmineOB

OpenBabel wrapper package for R

Other

9 stars 5 forks source link

r-universe build failing on vignette #33

Closed Aariq closed 8 months ago

Aariq commented 8 months ago

I noticed that the r-universe build of ChemmineOB is failing (https://github.com/r-universe/girke-lab/actions/runs/6231270933/job/17027636495#step:3:651) and it looks like the fix might be as easy as changing this line from pkg_ver to packages::pkg_ver:

https://github.com/girke-lab/ChemmineOB/blob/f2826b1e6c8c8f7d82143d5e38d7e61c133267a8/vignettes/ChemmineOB.Rmd#L5

tgirke commented 8 months ago

Since ChemmineOB is Bioc package there is no indication of a fail where it is hosted: https://bioconductor.org/checkResults/devel/bioc-LATEST/ChemmineOB/. When you maintain a lot of packages, the checks in different locations add to the workload. Nevertheless, we will address this. Thanks for letting us know.

Aariq commented 8 months ago

packages also needs to be added to Suggests in DESCRIPTION

khoran commented 8 months ago

So, actually, it needed to be r library(BiocStyle); pkg_ver('ChemmineOB'). BiocStyle is already in Suggests. Changed in version 1.39.3.