search

girke-lab / ChemmineR-git-svn-bridge

This is defunct, now replaced with https://github.com/girke-lab/ChemmineR
2 stars 6 forks source link

fix missing man pages for new functions #10

Closed khoran closed 10 years ago

khoran commented 10 years ago

not currently passing check on bioc: http://www.bioconductor.org/checkResults/devel/bioc-LATEST/ChemmineR/zin1-checksrc.html

khoran commented 10 years ago

can you please work on this soon? thanks.

tgirke commented 10 years ago

Which functions are those?

Thomas

On Mon, Jun 30, 2014 at 05:04:06PM +0000, kevin wrote:

can you please work on this soon? thanks.

— Reply to this email directly or view it on GitHubhttps://github.com/girke-lab/ChemmineR/issues/10#issuecomment-47557525.

khoran commented 10 years ago

Thomas, This was directed at Tyler, I didn't realize it would go to you also, sorry. Tyler added the functions: 'browseJob' 'launchCMTool' 'listCMTools' 'result' 'status' 'toolDetails'

awhile back and never documented them, so they cause a warning on the bioc page.

Kevin

On 06/30/2014 10:08 AM, Thomas Girke wrote:

Which functions are those?

Thomas

On Mon, Jun 30, 2014 at 05:04:06PM +0000, kevin wrote:

can you please work on this soon? thanks.

— Reply to this email directly or view it on GitHubhttps://github.com/girke-lab/ChemmineR/issues/10#issuecomment-47557525.

— Reply to this email directly or view it on GitHub https://github.com/girke-lab/ChemmineR/issues/10#issuecomment-47558015.

tgirke commented 10 years ago

Let's always make sure that if we check in a function to include a help file right away, then run R CMD check to remove all errors and warnings and then check on Bioc the next day whether the package was built properly. The documentation on the vignette also needs to be updated at the same time or no user will ever know about a new or modified function.

Thomas

On Mon, Jun 30, 2014 at 05:23:51PM +0000, kevin wrote:

Thomas, This was directed at Tyler, I didn't realize it would go to you also, sorry. Tyler added the functions: 'browseJob' 'launchCMTool' 'listCMTools' 'result' 'status' 'toolDetails'

awhile back and never documented them, so they cause a warning on the bioc page.

Kevin

On 06/30/2014 10:08 AM, Thomas Girke wrote:

Which functions are those?

Thomas

On Mon, Jun 30, 2014 at 05:04:06PM +0000, kevin wrote:

can you please work on this soon? thanks.

— Reply to this email directly or view it on GitHubhttps://github.com/girke-lab/ChemmineR/issues/10#issuecomment-47557525.

— Reply to this email directly or view it on GitHub https://github.com/girke-lab/ChemmineR/issues/10#issuecomment-47558015.

— Reply to this email directly or view it on GitHubhttps://github.com/girke-lab/ChemmineR/issues/10#issuecomment-47559857.

TylerBackman commented 10 years ago

Yes, I will take care of this.

Tyler

From: kevin [notifications@github.com] Sent: Monday, June 30, 2014 10:04 AM To: girke-lab/ChemmineR Cc: Tyler William H Backman Subject: Re: [ChemmineR] fix missing man pages for new functions (#10)

can you please work on this soon? thanks.

— Reply to this email directly or view it on GitHubhttps://github.com/girke-lab/ChemmineR/issues/10#issuecomment-47557525.

TylerBackman commented 10 years ago

This is done. I will also submit the new vignette updates once it will compile, I sent Kevin an e-mail about getting ChemmineOB to compile in my devel environment.