girke-lab / ChemmineR-git-svn-bridge

This is defunct, now replaced with https://github.com/girke-lab/ChemmineR
2 stars 6 forks source link

Added visualization script to R/ folder #20

Closed johnasharifi closed 9 years ago

johnasharifi commented 9 years ago

ChemmineR already had a visualization script which overloaded the plot() function. I added a new draw_sdf function which gives very similar functionality but should be a bit faster. I don't plan on overriding the original plot() function until someone tells me to, because I don't want to change functionality in dependent scripts.

tgirke commented 9 years ago

Once things are tested out, the best solution might be to add the new code to the existing plotting function while adding an argument where the user can choose which rendering style to use, e.g. graphics="base" -> old style graphics="ggplot2" -> new style

Thomas

On Tue, Sep 30, 2014 at 05:08:47PM +0000, johnasharifi wrote:

ChemmineR already had a visualization script which overloaded the plot() function. I added a new draw_sdf function which gives very similar functionality but should be a bit faster. I don't plan on overriding the original plot() function until someone tells me to, because I don't want to change functionality in dependent scripts.


You can merge this Pull Request by running

git pull https://github.com/johnasharifi/ChemmineR master

Or view, comment on, or merge it at:

https://github.com/girke-lab/ChemmineR/pull/20

Commit Summary

  • Testing commit to git
  • Update draw_sdf.r

File Changes

  • A R/draw_sdf.rhttps://github.com/girke-lab/ChemmineR/pull/20/files#diff-0 (283)

Patch Links:

— Reply to this email directly or view it on GitHubhttps://github.com/girke-lab/ChemmineR/pull/20.

khoran commented 9 years ago

John, I will merge this after the current bioc release, oct 14.

khoran commented 9 years ago

John, could you please create and add a man page for the draw_sdf function? I cannot export it as a function until it has a man page. Look a the "prompt" R function to help you create the man page.