search

girke-lab / ChemmineR-git-svn-bridge

This is defunct, now replaced with https://github.com/girke-lab/ChemmineR
2 stars 6 forks source link

Attempting to add draw_sdf help file #27

Closed johnasharifi closed 9 years ago

johnasharifi commented 9 years ago

Added a draw_sdf help file. I can't seem to view the contents of the file in an R terminal using ?draw_sdf or help(draw_sdf) though. Once I confirm the .rd file is working, I will prune old comments from the draw_sdf.r file.

khoran commented 9 years ago

John, Why did you close this before it was merged? Are you still working on it then?

Kevin

johnasharifi commented 9 years ago

Whoops, I thought "close pull request" meant something like "finalize pull request", not "cancel pull request".

khoran commented 9 years ago

the "?" won't work until the .Rd file is installed with the package. I'll check it and clean up the comments when I do the merge.

johnasharifi commented 9 years ago

Recent updates in my repo address pending issues with coding style.

khoran commented 9 years ago

The man page (draw_sdf.Rd) usage line is missing the argument "node_background_color". Please add that to the usage line and also document it under "argumenents". This will probably have to be a new pull request when you've done that.

johnasharifi commented 9 years ago

I issued a new request to pull from my ChemmineR repo, rather than pulling from only my draw_sdf.R file. I believe that will pull in changes to both draw_sdf.R and draw_sdf.Rd, which should address the issues with node_background_color being undocumented. If this pull is successful, I will close the old pull request that we were working off of.

On Mon, Jan 26, 2015 at 12:49 PM, kevin notifications@github.com wrote:

The man page (draw_sdf.Rd) usage line is missing the argument "node_background_color". Please add that to the usage line and also document it under "argumenents".

— Reply to this email directly or view it on GitHub https://github.com/girke-lab/ChemmineR/pull/27#issuecomment-71535297.

khoran commented 9 years ago

This pull request is already closed, which is the reason for the new request. Once I merge in the change from a pull request it closes it automatically.