search

girke-lab / ChemmineR-git-svn-bridge

This is defunct, now replaced with https://github.com/girke-lab/ChemmineR
2 stars 6 forks source link

Try to fix the fp2bit funtion in sim.R. from Songpeng #32

Closed beyondpie closed 9 years ago

beyondpie commented 9 years ago

When sdfset only contains one SDF element, fp2bit will get Error " fpma[ ,1]: incorrect number of dimensions." This is because the fpma[ , 1:154] in function fp2bit will return an array, if fpma only has one row. The same as fpbitma.

I try to fix this "bug" (I treat it as a bug), and I wonder whether it works for you? Also I am new about github, and sorry for any possible trouble.

tgirke commented 9 years ago

Easy to fix. Thanks for reporting this issue.

Kevin: will you take care of this? Adding drop = TRUE to '[,,,]' might fix this but I am not sure...

Thanks,

Thomas

On Tue, Apr 07, 2015 at 04:46:45PM +0000, Songpeng Zu wrote:

When sdfset only contains one SDF element, fp2bit will get Error " fpma[ ,1]: incorrect number of dimensions." This is because the fpma[ , 1:154] in function fp2bit will return an array, if fpma only has one row. The same as fpbitma.

I try to fix this "bug" (I treat it as a bug), and I wonder whether it works for you? Also I am new about github, and sorry for any possible trouble.

You can view, comment on, or merge this pull request online at:

https://github.com/girke-lab/ChemmineR/pull/32

Commit Summary

  • Fix the fp2bit funtion in sim.R.
  • Merge pull request #1 from songpeng/songpeng-patch-1

File Changes

  • M R/sim.Rhttps://github.com/girke-lab/ChemmineR/pull/32/files#diff-0 (2)

Patch Links:

— Reply to this email directly or view it on GitHubhttps://github.com/girke-lab/ChemmineR/pull/32.

beyondpie commented 9 years ago

Thanks for your reply. And I try drop = FALSE, and it really works. Much better way than mine~ Songpeng

Best Regards,

Songpeng Zu (祖松鹏), PhD candidate

Bioinformatics Division, TNLIST and Department of Automation. FIT Building 1-108, Tsinghua University, Beijing 100084, China. Phone(Lab): +86 10 62794294-838 Email: zusongpeng@gmail.com

On Wed, Apr 8, 2015 at 12:52 AM, Thomas Girke notifications@github.com wrote:

Easy to fix. Thanks for reporting this issue.

Kevin: will you take care of this? Adding drop = TRUE to '[,,,]' might fix this but I am not sure...

Thanks,

Thomas

On Tue, Apr 07, 2015 at 04:46:45PM +0000, Songpeng Zu wrote:

When sdfset only contains one SDF element, fp2bit will get Error " fpma[ ,1]: incorrect number of dimensions." This is because the fpma[ , 1:154] in function fp2bit will return an array, if fpma only has one row. The same as fpbitma.

I try to fix this "bug" (I treat it as a bug), and I wonder whether it works for you? Also I am new about github, and sorry for any possible trouble.

You can view, comment on, or merge this pull request online at:

https://github.com/girke-lab/ChemmineR/pull/32

Commit Summary

  • Fix the fp2bit funtion in sim.R.
  • Merge pull request #1 from songpeng/songpeng-patch-1

File Changes

  • M R/sim.Rhttps://github.com/girke-lab/ChemmineR/pull/32/files#diff-0 (2)

Patch Links:

— Reply to this email directly or view it on GitHub< https://github.com/girke-lab/ChemmineR/pull/32>.

— Reply to this email directly or view it on GitHub https://github.com/girke-lab/ChemmineR/pull/32#issuecomment-90643848.