search

girldevelopit / gdi-website

This is the official repository for the Girl Develop It website.
https://girldevelopit.com
MIT License
310 stars 378 forks source link

on clicking nav bar sponsors the header sponsors should be at the top of the page #309

Closed pshegde closed 9 years ago

pshegde commented 9 years ago

Description On clicking materials the materials header is at the top of the page. However, on clicking sponsors and donate the header is not at the top of the page.

Ask 1) adding a SUPPORTERS header at the top of this page, 2) changing the navigation link label to SUPPORTERS (Edited based on comments below by @DBNess and @kstack7 )

To Do Same as above

Additional Info untitled

kstack7 commented 9 years ago

Thank you for this issue and suggestion, @pshegde! Please reference our issue template #83 for future contributions. We'd greatly appreciate it!

I believe the reason for this lacking header is because we also mention our partners lower in the page. I'd love to hear what others think about this layout, too.

DBNess commented 9 years ago

Thank you, @pshegde! This is a great suggestion for design consistency -- we should have a header here with words and not just the flourish. I see @kstack7's point re: why Sponsors wouldn't make sense, though, so I wonder if maybe "SUPPORTERS" or "SPONSORS & PARTNERS" something general should be the page header and then we can keep the breakout between Sponsors and Partners down the page. Definitely +1 / :+1: Prajakta's suggestion, just want to figure out wording that makes sense. cc @corinnepw

kstack7 commented 9 years ago

Hmm yeah I almost wonder if we should swap out the nav for "supporters" so that we can use that as the header and "SPONSORS" / "PARTNERS" as the sub-headers...

DBNess commented 9 years ago

@kstack7 "supporters" isn't a convention on non-profit websites quite like "sponsors" is, but it's more accurate, so I'd say :+1: to renaming to Supporters & adding the header we see on the other pages for consistency.

DBNess commented 9 years ago

@pshegde could you please reformat this issue to follow the template here (you can copy & paste the markdown from this link into this issue to edit) and request 1) adding a SUPPORTERS header at the top of this page, and 2) changing the navigation link label to SUPPORTERS, when you get the chance? Thank you!

kstack7 commented 9 years ago

Yea @DBNess my only concern was "supporters" reading as "support" which could clash with "donate" hah but "supporters" does make the most sense out of these options.

kstack7 commented 9 years ago

K so I'm rerouting the config to support the new "supporters" page in place of "sponsors" but I have not gone as deep as to update all the CSS/class names. How do we feel about that?

Also, with with or without the flourish? Any designers want to chime in?

Without flourish -- without

With flourish -- with

kstack7 commented 9 years ago

Also, I'm assuming we have the /sponsors mentioned elsewhere so I added a redirect for that cause...

DBNess commented 9 years ago

Great, Kristen! Good call on the redirect, always good to remain backwards-compatible. Maybe ship this without CSS class renames, but create a followup issue for someone to refactor the class names? That way it happens, but we create an opportunity for someone else to help out and limit risk by narrowing the scope of changes.

On Wednesday, May 13, 2015, Kristen notifications@github.com wrote:

Also, I'm assuming we have the /sponsors mentioned elsewhere so I added a redirect for that cause...

— Reply to this email directly or view it on GitHub https://github.com/girldevelopit/gdi-new-site/issues/309#issuecomment-101515119 .

Vanessa Hurst Co-Founder | Girl Develop It http://www.girldevelopit.com | @girldevelopit http://twitter.com/girldevelopit

Girl Develop It http://girldevelopit.com/ teaches women to code in over 45 cities CodeMontage http://www.codemontage.com/ empowers coders to change the world Women coders break new ground, and stereotypes - TODAY show http://www.today.com/video/today/53924117

kstack7 commented 9 years ago

@minamarkham this is the one I'm talking about...

@Cara-Jo any preferences here, too? Not sure if we want to keep that flourish, change the headers of Sponsors/Partners, or something else that's creative. Thoughts?

kstack7 commented 9 years ago

@DBNess great idea with the scope creep. I'll keep this one simple for now and open the next CSS swapping issue :)

minamarkham commented 9 years ago

@kstack7 no flourish :)

kstack7 commented 9 years ago

Yeah it did seem out of place...but what if we moved it under the paragraph? meh I'm "take it or leave it" either way haha

kstack7 commented 9 years ago

Up on staging -- https://girl-develop-it-staging.herokuapp.com/supporters

TrishaChetani commented 9 years ago

Hi , I want to join you people and learn more about coding , If you are free and can help me to understand what you guys are doing ?

kstack7 commented 9 years ago

Hello @Trisha1212 and welcome to Girl Develop It's website repo! The site is open to the public and we welcome suggestions, ideas, contributions, etc. If you're curious about us as an organization, why not start by checking us out at https://www.girldevelopit.com/about

TrishaChetani commented 9 years ago

I am excited to learn and develop the skills , i checked with few people who are listed in site they asked my location(India) and skills experience and said we dont work outside US . hence i checked your git hub repository and thought to sync with you . we can have online discussions and learn and share from each other . if you don't mind

kstack7 commented 9 years ago

Nope! We keep this repo wide open for these reasons :) Feel free to browse more of our existing issues (https://github.com/girldevelopit/gdi-new-site/issues) and jump in!

TrishaChetani commented 9 years ago

Sure . Thank you