girlscript / Girscript-Community-Website

Official Community Website for Girlscript Foundation

MIT License

15 stars 43 forks source link

Testimonial Component Created #62

Closed Castella1313 closed 3 years ago

Castella1313 commented 3 years ago

60 issue solved

This is how it looks like now - Screenshot 2021-03-25 at 7 46 21 PM

Castella1313 commented 3 years ago

@codewithvk Can you please check my PR?

codewithvk commented 3 years ago

@Castella1313 it's LGFM :) here are some changes. increase gap between mission and testimonial Increase the size of the testimonial. You can see sample in Issue:)

Castella1313 commented 3 years ago

@codewithvk Done

Now - Screenshot 2021-03-26 at 10 34 17 AM

codewithvk commented 3 years ago

@Castella1313 LGFM :)

codewithvk commented 3 years ago

@Castella1313 Apologies for my mistake,

Could you please make a new pr with some of these changes? 1) Fetch data from the repo and create structure accordingly. 2) On every page width and height make sure 100%.otherwise, it not comfortable with other pages. Image of my browser : test1 You can see here white part on the right side and bottom. Thanks!

Castella1313 commented 3 years ago

@codewithvk I am just wondering how is this happening, the width is already 100% and height is auto. It's even working perfect in Chrome and Safari. Screenshot 2021-03-26 at 12 49 47 PM

codewithvk commented 3 years ago

Chrome and Saf

Then go ahead with it. It might happen because I switch 17-inch display device recently. You can make pr, I will cross-check with other mentors :)