girlscript / gssoc-website-new

GSSoC'24 Official Website
https://gssoc.girlscript.tech
71 stars 74 forks source link

Enhanced Pagination Tool #302

Closed partha120804 closed 2 days ago

partha120804 commented 3 days ago

Added a pagination on top of the table, so that you don't have to scroll down to change the page.

Added a button to change how many contributors they want on a page ( currently it is fixed to 50). added a drop down for 10,25,50,100,200,500,1000.

fixes #281

Works on my device smoothly. Also checked for mobile devices.

Removed the search icon from search bar as typing in search bar automatically triggers search so there's no need of a separate button.

PC: image

Mobile: image

Please assign me under GSSOC

partha120804 commented 3 days ago

🤔 @sanjay-kv The pagination on the bottom of the page is very hard to access,

Because if someone toggles the 500 per page option he will have to scroll very long to access the pagination part, as mobile devices don't have a scroll bar, so it's kind of useful to have pagination at the top of the page,

Can we keep it ???

I can try to make it less messy ?

partha120804 commented 3 days ago

@sanjay-kv I have commented out the pagination part, And switched the positions of rows per page and search bar.

Adding the "rows per page" dropdown in the highlighted area looks good on big screens but on mobile devices it's very very bad ☠️, tried some alterations but it's just not suitable, so added that on the left side.

sanjay-kv commented 2 days ago

image

i still see the same while code review is it the correct PR?

partha120804 commented 2 days ago

No, their position have been changed with the recent commit

Ref : https://github.com/girlscript/gssoc-website-new/commit/7abc2d4999a8ff931951f827d114d4b83204f361