girzel / ebdb

An EIEIO port of BBDB, Emacs' contact-management package
67 stars 11 forks source link

Add some org-roam integration #109

Closed swflint closed 7 months ago

swflint commented 1 year ago

I'd like to add some org-roam integration to EBDB.

The start will be a section for the org-roam-buffer, and ideally, a way to integrate notes.

girzel commented 6 months ago

Hey I realized, way after the fact, that this code contains reference to a function org-roam-ebdb-function that appears not to exist, and the byte compiler is choking on that. Does that function live somewhere else? Thanks.

swflint commented 6 months ago

What line?

girzel commented 6 months ago

Sorry! org-roam-ebdb-section, I had "function" on the brain. The second line of ebdb-roam-section: (magit-insert-section (org-roam-ebdb-section). Is this actually a function, or is the magit-insert-section macro doing something funky with it? Either way, I have to tell the compiler what to do with it.

swflint commented 6 months ago

It's the latter. IIRC, you should be able to prefix with an underscore.

girzel commented 6 months ago

Ah, I see. I had to remove the parentheses around it (magit says it should be a symbol) and then wrap it in with-suppressed-warnings, but all is good now. Thanks!