search

girzel / ebdb

An EIEIO port of BBDB, Emacs' contact-management package
67 stars 11 forks source link

`seq` required, no `seq-sort-by` #67

Closed swflint closed 6 years ago

swflint commented 6 years ago

I have Emacs 25.3.1, seq 2.3. seq-sort-by does not exist.

girzel commented 6 years ago

Bother -- that hadn't occurred to me. You must be running EBDB from git, right? I'll drop the use of that (though it was very handy) and figure out which version of seq includes seq-sort-by.

Thanks for the report.

girzel commented 6 years ago

Oh... EBDB has a Package-Requires with (seq "2.15"), which does include `seq-sort-by'. The Elpa repo has seq 2.20 available. I think if you'd installed EBDB through the package manager, it would have brought down seq 2.20 as well, as a dependency.

I encourage people to run EBDB from git, as I get early-warning bug reports, but I think if you do that you'll have to handle the dependencies yourself, by installing a newer version of seq from the repos.

swflint commented 6 years ago

I am running from git, and I'll take a look in elpa. It does appear that more recent versions of seq may have removed seq-sort-by.

girzel commented 6 years ago

Pretty sure seq 2.20 has seq-sort-by in it -- try installing that?

swflint commented 6 years ago

That's still a version previous to what I have. Either way, where would I find said previous version?

girzel commented 6 years ago

No, Elpa uses a semver-style versioning scheme, meaning that 2.20 is greater than 2.3. If you use the GNU package repository, meaning that your package-archives contains ("gnu" . "https://elpa.gnu.org/packages/"), then you should be able to find seq 2.20 there.

swflint commented 6 years ago

I did update it and I'm still getting the error. As a note, I use almost nothing from Melpa or Elpa -- so using it to update packages is foreign to me.

girzel commented 6 years ago

I'm not sure what to tell you... After installation, in the directory pointed to by package-user-dir, there should be a directory called "seq-2.20", and the contents of that should look like: https://git.savannah.gnu.org/gitweb/?p=emacs/elpa.git;a=tree;f=packages/seq

If you're using Emacs 25, loading seq.el should load seq-25.el, which contains seq-sort-by.

Does any of that seem wrong?

swflint commented 6 years ago

Go figure. Sadly, it still doesn't work.

girzel commented 6 years ago

Last ditch question, before I give up and replace the call to seq-sort-by: what do you get for (locate-library 'seq) and (locate-library 'seq-25)?

Thanks...

swflint commented 6 years ago

Turns out I had installed it previously and forgotten about it. Sorry for the waste of time.

girzel commented 6 years ago

Glad it got sorted!