search

girzel / ebdb

An EIEIO port of BBDB, Emacs' contact-management package
67 stars 12 forks source link

make ebdb find mu4e 1.6.x buffer #97

Closed secomi closed 2 years ago

secomi commented 2 years ago

mu4e 1.6.x switch to GNUS as default view and buffer is now gnus-article-buffer.

secomi commented 2 years ago

That is correct the variable mu4e-view-use-old seems to have been introduced in 1.6. And will be removed in 1.7 unreleased yet.

I'll resend a PR with your suggestion. Thanks

On Sat, 9 Oct 2021 at 00:12, Eric Abrahamsen @.***> wrote:

@.**** commented on this pull request.

Thanks for this! I'm assuming the variable mu3e-view-use-old isn't present in earlier versions of mu4e, right? Would it make sense to use (bound-and-true-p mu4e-view-use-old) as the test instead?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/girzel/ebdb/pull/97#pullrequestreview-775481857, or unsubscribe https://github.com/notifications/unsubscribe-auth/AG757JHAYK42O4OBWKUTYFTUF5UE5ANCNFSM5FULLSFQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

girzel commented 2 years ago

Thanks! I hope they don't remove the option so quickly -- once it's gone how will we know if we're "before" the option or "after" the option? Anyway, we can worry about that later, I'll put this in now.

secomi commented 2 years ago

Thank you. Great

On Sat, Oct 9, 2021, 17:32 Eric Abrahamsen @.***> wrote:

Merged #97 https://github.com/girzel/ebdb/pull/97 into master.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/girzel/ebdb/pull/97#event-5438246424, or unsubscribe https://github.com/notifications/unsubscribe-auth/AG757JANKAE6CHC5HASOA4LUGBN7DANCNFSM5FULLSFQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.