search

girzel / gnorb

Glue code between the Org, Gnus, and BBDB packages for Emacs.
32 stars 4 forks source link

Fix problems when BBDB is not present and gnorb-bbdb is not loaded. #5

Closed malcolmpurvis closed 10 years ago

malcolmpurvis commented 10 years ago

I'm experimenting with gnorb but have BBDB 2 installed, and therefore don't want to try gnorb's BBDB integration. I don't load gnorb-bbdb, but still have to make the following changes to run gnorb without errors.

I hope that you find the patch useful.

girzel commented 10 years ago

Thanks very much for this! I started out with the idea that individual modules should be loadable in isolation, then quickly gave up on trying to make that work. If it's really this easy, that's very nice. I'm going to take a day or two to play with this, but at first glance it certainly looks good.

malcolmpurvis commented 10 years ago

I'm glad that you like it. I think that it would be a good idea to not require BBDB 3 to use the rest of gnorb. The conversion from BBDB 2 is non trivial and I'd like to use both for a while. (Who knows, gnorb's awesomeness may convince be to upgrade to BBDB 3!)

girzel commented 10 years ago

Okay, just those two queries, the other changes look very nice, thank you. In the end I think what I should do is tell people they need to be using BBDB 3, but then also put some backwards-compatibility guards in for BBDB 2. No need to be quite so aggressive... But I do hope Gnorb will push you towards BBDB version 3! It may be a little pain to set up, but it works much better than the last version...

malcolmpurvis commented 10 years ago

Thanks for the review. I don't mind you requiring BBDB 3 for the full gnorb functionaity. I'd just like some gnorb functionality to work when BBDB's not installed.

girzel commented 10 years ago

Okay this looks good, except for the one require statement which I'd like to keep, see note above. Can you make that one change, then I'll merge the branch?

girzel commented 10 years ago

Pulled this locally and added another commit...