search

gis-ops / docker-valhalla

This is our flexible Docker repository for the Valhalla routing engine
MIT License
240 stars 70 forks source link

latest image is not up-to-date #29

Closed nilsnolde closed 3 years ago

nilsnolde commented 3 years ago

something must've happened when we switched to valhalla's docker image as base image instead of rolling our own: the code is pretty old in latest image (see https://github.com/valhalla/valhalla/issues/3266 where it was reported).

nilsnolde commented 3 years ago

no more time right now, but I've found is that the current latest has valhalla executables from July 20th, which happened to be the latest release day of 3.1.3.. wtf.. also had a look in the most recent valhalla/valhalla:run-latest image and there the date is correctly Aug 24th, so it can't be the base image either.. then I looked at the image that'd been pushed to dockerhub last saturday and in there the exe's are from April 30th (no valhalla release day..). don't understand..

relevant part of the deployment script:

git pull
docker pull valhalla/valhalla:run-latest
docker pull ubuntu:20.04
docker build -t gis-ops/valhalla:latest .

# push to dockerhub
docker push gisops/valhalla:latest

can't see anything wrong in there..

nilsnolde commented 3 years ago

omg..

docker build -t gis-ops/valhalla:latest . vs docker push gisops/valhalla:latest (gisops & gis-ops) :roll_eyes:

so we're just pushing the exact same image since more than a month..

nilsnolde commented 3 years ago

I built a new image yesterday, just checked it: works.