Closed olehlong closed 2 years ago
Makes sense to me - what do you think @nilsnolde ?
yep, that's a good change I think.. in case you wanna do anything further with the tiles (like adding traffic) you'd need them raw anyways. if you don't want them, delete them yourself.
on the other hand, and that's a problem that existed before, it's not very intuitive probably that users will need 2 times the disk space for a single tilset (one tar, one plain). I'm thinking we could add a flag to the env vars to control whether a tar should be actually built automatically, defaulting to True
(running on a tar makes valhalla much faster). also we recently changed the behavior, now we actually have valhalla_build_extract
which produces a indexed tar for magnitudes faster loading times: https://github.com/valhalla/valhalla/pull/3281
haha just ramblings, PR is good as-is, tests pass, thanks @olehlong
I'm not 100% sure, but I think valhalla_tiles should be in the custom_tile_folder. But if it suppose to be deleted after valhalla_tiles.tar file creation, then we should add "--remove-files" to the tar command.