gis-ops / pyvalhalla

High-level Python bindings to the Valhalla routing framework.
GNU General Public License v2.0
57 stars 4 forks source link

Cannot install for Python 3.12 #35

Open pintergreg opened 2 months ago

pintergreg commented 2 months ago

I use poetry, but I think the problem is with the Python version (3.12), as I cannot install with pip either.

poetry install
Updating dependencies
Resolving dependencies... (5.9s)

Writing lock file
Installing dependencies from lock file

Package operations: 1 install, 0 updates, 0 removals

  - Installing pyvalhalla (3.2.0): Failed

  RuntimeError

  Unable to find installation candidates for pyvalhalla (3.2.0)

  at /usr/lib/python3.12/site-packages/poetry/installation/chooser.py:74 in choose_for
       70│ 
       71│             links.append(link)
       72│ 
       73│         if not links:
    →  74│             raise RuntimeError(f"Unable to find installation candidates for {package}")
       75│ 
       76│         # Get the best link
       77│         chosen = max(links, key=lambda link: self._sort_key(package, link))
       78│ 

Cannot install pyvalhalla.
$ pip install --user -U pyvalhalla
ERROR: Could not find a version that satisfies the requirement pyvalhalla (from versions: none)
ERROR: No matching distribution found for pyvalhalla
baileyheading commented 2 months ago

Did you try making an environment with python 3.11 to test your own theory?

also, what platform are you on?

nilsnolde commented 2 months ago

Yeah we don’t publish wheels for 3.12 yet. There’s no particular reason, I just didn’t touch the project since it came about. I can try later and hope it works without any changes.

pintergreg commented 2 months ago

Did you try making an environment with python 3.11 to test your own theory?

Yes, I did. And it works.

also, what platform are you on?

I was using pyvalhalla under Python 3.11 for a year, but Archlinux updated to 3.12 recently.

There’s no particular reason, I just didn’t touch the project since it came about.

I disagree with the first part of the sentence. There is a very good reason to support 3.12 as it is the latest stable Python version, which was just included into Ubuntu 24.04 LTS.

As for the second part, I can perfectly understand if you don't have time for this project (anymore).

I can try later and hope it works without any changes.

Thank you.

nilsnolde commented 2 months ago

I disagree with the first part of the sentence.

that’s not what I was referring to. I meant that there no reason why we didn’t publish wheels for that yet other than not touching the project for a while, there was no other need to.

anyways, we’ll try soon. I’m on Manjaro, their arch mirrors should update soon as well then, but so far we’re on 3.11.

nilsnolde commented 2 months ago

at least it worked for linux. we'll see now if mac/win also works. then I'll publish them for 3.12.

nilsnolde commented 2 months ago

it won't fix for now, see #37 for reasoning