search

gis-ops / routingpy

🌎 Python library to access all public routing, isochrones and matrix APIs in a consistent manner.
https://routingpy.readthedocs.io/en/latest/?badge=latest
Apache License 2.0
270 stars 26 forks source link

[bugfix] costing removed as params for mapbox_osrm #23

Closed RemaniTinpo closed 3 years ago

RemaniTinpo commented 3 years ago

Hi @nilsnolde, Does your comment is linked to the second point of my issue ?

nilsnolde commented 3 years ago

Jep, right. We can leave the readme as-is and change the code to not require mapbox/xxx, just like the other MapboxOSRM functions. Was also an oversight apparently. Just gotta be a little careful to do it backwards-compatible, e.g. profile.replace('mapbox/', '') in the isochrones function, so old code will continue to work.

RemaniTinpo commented 3 years ago

Sorry, it was a busy week. Let me know if it's ok like this, or if you prefer something more.

nilsnolde commented 3 years ago

We'd like to release pretty soon and this fix would be nice to have. @RemaniTinpo if you wanna finish this would be cool, if no time, I'll add the missing pieces, no worries.

RemaniTinpo commented 3 years ago

Thanks, I didn't catched the move to black. It's very nice btw you changed for black. And sorry for the delay, awfull week, I will stay tuned today !

nilsnolde commented 3 years ago

jep that's it:)