Fix#22 - Githubissues

gis-ops / routingpy

🌎 Python library to access all public routing, isochrones and matrix APIs in a consistent manner.

https://routingpy.readthedocs.io/en/latest/?badge=latest

Apache License 2.0

253 stars 26 forks source link

Fix#22 #24

Closed chrstnbwnkl closed 3 years ago

chrstnbwnkl commented 3 years ago

Changed Router base class to be BaseClient base class
Added Client class derived from BaseClient that uses requests
Updated all routers to have clientargument with Clientas default value

Caveats:

args passed to router not available via router instance, only through router's client instance (e.g. router.client.proxies instead of router.proxies)

nilsnolde commented 3 years ago

Can you merge master into this branch? Only changed formatting stuff. Also, don't forget to re-install the pre-commit hook with pre-commit install.

nilsnolde commented 3 years ago

smth is not quite right with the linting still.. tons of formatting changes in this PR. don't sweat it though, could also be a mismatch of CI and local stuff: your latest commit passed but it shouldn't have. we'll figure that out after we merged this PR, as long as CI is happy.