search

gis-ops / routingpy

🌎 Python library to access all public routing, isochrones and matrix APIs in a consistent manner.
https://routingpy.readthedocs.io/en/latest/?badge=latest
Apache License 2.0
252 stars 26 forks source link

Fix#35 #39

Closed chrstnbwnkl closed 2 years ago

chrstnbwnkl commented 2 years ago

This fixes #35 by adding an order argument to the polyline decoder methods, and reversing it for OSRM's directions response parsing. Mock responses in OSRM tests are updated to reflect this change.

nilsnolde commented 2 years ago

Oops still missing the test adjustment.. when you added that, feel free to just merge after

nilsnolde commented 2 years ago

I adjusted the tests @chrstnbwnkl . couldn't find my own implementation of the 3D polyline stuff anymore, but in case you ever need it, graphhopper has one: https://github.com/graphhopper/graphhopper/blob/bded5ba499a94a82a509131d761fcd88667773f3/web-api/src/main/java/com/graphhopper/jackson/ResponsePathSerializer.java

easily ported to python's polyline package. maybe I PR that one of these days..