nilsnolde
commented
2 years ago Just noticed that we could also get rid of the **kwargs passed to Valhalla.{directions(), isochrones(), matrix()}
good point @chrstnbwnkl , that should actually be another issue. we don't handle them right now but we should. really for every single router and method we should have **kwargs which we then append as-is to the routing request. it's more a way of relaxing ourselves a little so that new router-specific parameters which aren't implemented yet in routing-py can be still be specified.
I only changed valhalla & osrm, as those two are the only ones we can use via python bindings in downstream projects. it's pretty mechanical changes anyways