search

gis-ops / routingpy

🌎 Python library to access all public routing, isochrones and matrix APIs in a consistent manner.
https://routingpy.readthedocs.io/en/latest/?badge=latest
Apache License 2.0
252 stars 26 forks source link

supply **kwargs to all methods of all routers #42

Open nilsnolde opened 2 years ago

nilsnolde commented 2 years ago

in https://github.com/gis-ops/routing-py/pull/41#commitcomment-55187341 we realized that the **kwargs are not even used when they're passed to a method. instead of removing that parameter, we should make use of it and simply append the whole thing to the request parameters. reason is that we likely won't keep up here with all the changes of the individual router arguments to APIs which will be added in the future and this provides a means of passing those anyways, sort of a safety net for our (and the community's!!!) laziness;)

nurikk commented 2 years ago

This is exactly what I need! I've created PR adding kwargs support for osrm https://github.com/gis-ops/routing-py/pull/49

nurikk commented 2 years ago

Please help to review https://github.com/gis-ops/routing-py/pull/59