search

gis-ops / routingpy

🌎 Python library to access all public routing, isochrones and matrix APIs in a consistent manner.
https://routingpy.readthedocs.io/en/latest/?badge=latest
Apache License 2.0
252 stars 26 forks source link

added e2e tests, some minor response parsing fixes #85

Open chrstnbwnkl opened 1 year ago

chrstnbwnkl commented 1 year ago

I left the mocked request tests for now, because a) we still need them for non-FOSS routers and b) they do help with testing the parsing and request building. For now, the e2e tests are also just pretty basic, we can add more sophisticated ones as time moves on, what do you think @nilsnolde ?

nilsnolde commented 1 year ago

Also, seems like the PBF is not pushed up.

chrstnbwnkl commented 1 year ago

Adressed most comments now except the ones pertaining to the isochrone locations parameter, this should probably be adressed in a separate PR?

nilsnolde commented 1 year ago

hm, some tests failing.. will need to wait a bit.