search

gis-ops / routingpy

🌎 Python library to access all public routing, isochrones and matrix APIs in a consistent manner.
https://routingpy.readthedocs.io/en/latest/?badge=latest
Apache License 2.0
270 stars 26 forks source link

add alternates to valhalla #87

Open nilsnolde opened 1 year ago

nilsnolde commented 1 year ago

Didn't do a test. I'd wait for #85 to be merged and do a live test.

nilsnolde commented 1 year ago

I actually think we need some general re-write of all of this.. We've been patching a lot of shit in the past 12 months, like the static functions so we can use its logic outside of routingpy. All the typing is really off. Now I saw we're generally returning a Direction object, unless it's with alternatives, then we return a Directions (plural) object. That's really stupid haha. We can collect some ideas about v2.

nilsnolde commented 1 year ago

I was just very surprised by the weird conflicts, turns out you accidentally approved the wrong pull request :smile: