Support Graphhopper's POST Route Endpoint

[jan-bausch]

Graphhopper supports both a GET and a POST directions endpoint. However, the GET endpoint has some limitations:

For the GET request you specify the parameters in the URL and can try it directly in every browser. However, it has some disadvantages when using many points (URL length limit) and the custom_model Feature cannot be used. Therefore, our recommended endpoint is the POST route endpoint.

(Quote from the Graphhopper docs)

Currently, routingpy only supports the GET endpoint. It would be cool to use POST, to be able to set custom models!

[nilsnolde]

Jep right. They must've added POST a while ago. They went through 6 major versions in the past 2 years, can't keep up with that;)

We hardly ever work with Graphhopper, but would appreciate a PR fixing it.

[jan-bausch]

Do you prefer

a) replacing the GET with the POST request alltogether, or b) adding an optional parameter to use the POST endpoint?

[jan-bausch]

Intuitively, I'd go for a), as the endpoints should be interchangeable. What's your opinion?

[nilsnolde]

Do you think GET is interesting for any scenario? Is there an action that's GET only or so? Valhalla has both too, but we only do POST since there's not GET-only ones. It'd be easiest here too IMO.

[jan-bausch]

I agree 👍 Based on the docs, there are no drawbacks, and POST is clearly recommended.

[jan-bausch]

I can work on a small PR, if I find the time 👌

[jan-bausch]

Created https://github.com/gis-ops/routingpy/pull/91

[jan-bausch]

Any chance for a quick review, @nilsnolde ?

[nilsnolde]

was done in #91 & #92 , thanks again:)