gis-ops / valhalla-app

This is the demo web app running on https://valhalla.openstreetmap.de
https://valhalla.openstreetmap.de
MIT License
163 stars 90 forks source link

[FEATURE] Setting timeout of 'copied' in Leaflet popup #109

Closed aaryahjolia closed 1 year ago

aaryahjolia commented 1 year ago

Description

What kind of feature you are suggesting?

In the leaflet popup containing information of latitude, longitude, etc., After we click on copy icon, the green box containing 'copied' message does not vanish after few seconds.

Does it solve any problem?

If a user wants to copy another information from the popup, He/she should be able to know that the information is copied by discarding first copied message after few seconds and giving another copied message again.

Screenshots

image

Additional information

I would like to solve this issue as a part of pre-gsoc work.

nilsnolde commented 1 year ago

Jep, agreed, it'd be better UX. IMO 1 sec delay is enough, just a quick feedback that it was copied.

inceptionabhishek commented 1 year ago

I already implemented the same thing but at a different place. #96

aaryahjolia commented 1 year ago

I already implemented the same thing but at a different place. #96

Agree, this place also requires the same thing.

Jep, agreed, it'd be better UX. IMO 1 sec delay is enough, just a quick feedback that it was copied.

Perfect, I'll raise a PR with 1 sec delay.