search

gis-ops / valhalla-app

This is the demo web app running on https://valhalla.openstreetmap.de
https://valhalla.openstreetmap.de
MIT License
157 stars 87 forks source link

Update Costing Options solved #117

Closed hs7898753 closed 1 year ago

hs7898753 commented 1 year ago

🛠️ Fixes Issue

Closes #32

👨‍💻 Changes proposed

 Update with more costing options.

📄 Note to reviewers

📷 Screenshots

hs7898753 commented 1 year ago

I added bike-share as an option in the bicycle type. Is it appropriate to keep it there or somewhere else?

nilsnolde commented 1 year ago

Hm, no, this is not adding bike-share as an option. It's a slightly bigger job to add that, so let's remove anything bss-related from this PR.

I'm not happy with "profile" vs "general" settings. I didn't go through the whole thing in detail, but I saw that e.g. that only truck gets gate_cost. I'd ask you to go through the documentation and rectify what's available for which costing option. Also, even before this PR this wasn't done really correctly, but still, doesn't mean we shouldn't do a better job in the future..