search

gis-ops / valhalla-app

This is the demo web app running on https://valhalla.openstreetmap.de
https://valhalla.openstreetmap.de
MIT License
157 stars 87 forks source link

[BUG] Search Results Trapped Inside Scrolling #123

Closed tommach591 closed 1 year ago

tommach591 commented 1 year ago

Description

What is the problem you are facing

I noticed that the search results still become part of the scrolling after it extends in size at the 6+ waypoint.

What is your suggested solution

I am suggesting to instead set the min height to the 6th waypoint and increase the height per waypoint. Also to move the scrolling to the outer div so that the search results will not become part of the scrolling inside the list of waypoints.

Screenshots

Issue Capture

Suggested Capture2

AFZL210 commented 1 year ago

If no one is working on this, can I work on this issue?

rakeshhotker commented 1 year ago

am working on it,

rakeshhotker commented 1 year ago

so far i realized that need to do a patch to semantic.css file inside semantic-ui-css package, @nilsnolde suggest if i should continue with this approach. The output would be like this: image

tommach591 commented 1 year ago

I already have it done, I just need to make the pull request. I just added a inline min-height css. The outer div was already scrollable.

rakeshhotker commented 1 year ago

I didn't find the outer div scrollable, so took this approach as it was suggested in a closed issue with Search in semantic ui. @nilsnolde.

tommach591 commented 1 year ago

Sorry, not div, it turns out it was the Drawer component with the inline style 'overflow: auto' in components/Controls/index.jsx that made it scrollable.