search

gis-ops / valhalla-app

This is the demo web app running on https://valhalla.openstreetmap.de
https://valhalla.openstreetmap.de
MIT License
163 stars 90 forks source link

[BUG] Weird Bug in Height Graph Icon. #124

Open inceptionabhishek opened 1 year ago

inceptionabhishek commented 1 year ago

Description

What is the problem you are facing

As I was going through the issue I raised last week #114, I found another bug in the height graph icon.

To see the error follow the steps:-

  1. Open app( If you do not have it installed in your machine then visit : https://valhalla.openstreetmap.de/ ).
  2. Then click on the height graph icon, it's on the bottom right.
  3. Now try to enlarge the icon after hovering on it.
  4. The icon automatically moves to the left out of nowhere.
  5. After that all its functionality is gone (it's not expanding, not showing a height graph, div not enlarging even if two positions are fixed).

What is your suggested solution

It should follow the expected leaflet graph, like this https://giscience.github.io/Leaflet.Heightgraph/

Note 👍 :

I am spending a lot of time finding new issues and working on them to prepare for GSoC 2023, Hope You guys will consider my application. Thanks.

Screenshots

https://user-images.githubusercontent.com/65409282/224640864-209de66e-d740-4b4e-8c50-3462edf61b45.mp4

nilsnolde commented 1 year ago

Weird edge case yeah. Good to know about it (and fix eventually), but rather low prio IMO.

I am spending a lot of time finding new issues and working on them to prepare for GSoC 2023, Hope You guys will consider my application

Sure, we consider all applications for people who showed some interest and were communicative. The hope is to some degree that people also want to contribute to open-source out of conviction, not only opportunism:) Anyways, thanks for your contributions so far.

inceptionabhishek commented 1 year ago

Yeah, thanks. I also believe that this is currently low priority in comparison to other issues that we have here. I raised this issue because it is somewhat related to the previous issue regarding the height graph, and I thought it would be better to raise it so that they could work together on both issues.

nilsnolde commented 1 year ago

Always good to collect all sorts of issues, no matter the priority.

TyRoopam9599 commented 1 year ago

@inceptionabhishek Can you assign this issue to me?