search

gis-ops / valhalla-app

This is the demo web app running on https://valhalla.openstreetmap.de
https://valhalla.openstreetmap.de
MIT License
157 stars 87 forks source link

Closes #123 #125

Closed rakeshhotker closed 1 year ago

rakeshhotker commented 1 year ago

🛠️ Fixes Issue

Closes #123

👨‍💻 Changes proposed

In the semantic-ui-css package, added height: 200px and overflow-y:scroll for the .ui.search > .results selector. Since it's a change in the node-modules, to add the patch followed the following steps: 1) Install patch-package: "npm install patch-package -D" 2) add postinstall script: "scripts": { "postinstall": "patch-package" } , added the above code in package.json file 3) Run patch-package to create a .patch file: "npx patch-package semantic-ui-css" 4) Apply your fix via npm package manager: "npm install"

📄 Note to reviewers

Please suggest any changes required

📷 Screenshots

This is how it looks. Screenshot from 2023-03-13 23-13-41

rakeshhotker commented 1 year ago

i couldn't find one. But there's another PR from @tommach591 which claims to fix it. So am closing this one. Thanks. @nilsnolde.

rakeshhotker commented 1 year ago

I will close it if you think @tommach591 PR is good enough to solve the issue @nilsnolde.