search

gis-ops / valhalla-app

This is the demo web app running on https://valhalla.openstreetmap.de
https://valhalla.openstreetmap.de
MIT License
163 stars 90 forks source link

Change the issues template action #129

Closed nilsnolde closed 1 year ago

nilsnolde commented 1 year ago

What would you like to share?

In #95 we added issue templates. I think that's a good thing, however, it'd be more legible if we didn't use [FEATURE] sort of prefixes. Ideally we'd let Github label the issue appropriately, which is much more pleasing visually.

Ananya2001-an commented 1 year ago

GitHub doesn't add labels automatically. Currently the issue template has the labels section with which it assigns a label to the issue.

Ananya2001-an commented 1 year ago

If you want we can remove it from the template so that we can add labels manually.

nilsnolde commented 1 year ago

I‘m pretty sure it’s possible to add labels via templates automatically. But we can get to that when we started the whole thing, it’s not really urgent:)

Ananya2001-an commented 1 year ago

Yeah in the issue template I have added the labels prop which should add a label as soon as someone creates an issue but it's not working for some reason which is weird. But you are right we can look into that later. 👍🏼

hs7898753 commented 1 year ago

@Ananya2001-an The issue with your YAML code is that the labels field should not be enclosed in single quotes. YAML uses square brackets [] to indicate an array, so you should enclose your label name in square brackets.

your code: labels: ['🐛bug'] correct code : labels: [bug]

Ananya2001-an commented 1 year ago

@Ananya2001-an The issue with your YAML code is that the labels field should not be enclosed in single quotes. YAML uses square brackets [] to indicate an array, so you should enclose your label name in square brackets.

your code: labels: [🐛bug] correct code : labels: [bug]

Thanks for figuring out @hs7898753 I think I should have used double quotes instead. You can see this: https://github.com/EddieHubCommunity/LinkFree/blame/main/.github/ISSUE_TEMPLATE/bug.yml

hs7898753 commented 1 year ago

Yeah! Using double quotes is more useful to categorize issues based on multiple criteria. at this time there are only few labels available in this repo, you can create new labels to add to templates, ex: other.

nilsnolde commented 1 year ago

This is done