search

gis-ops / valhalla-app

This is the demo web app running on https://valhalla.openstreetmap.de
https://valhalla.openstreetmap.de
MIT License
157 stars 87 forks source link

[BUG] Overlay menu pushes the other leaflet controls down #132

Closed suyashvsingh closed 1 year ago

suyashvsingh commented 1 year ago

Description

What is the problem you are facing

When we hover over the Overlay menu toggle, the menu opens, but its pushes the other leaflet controls below it.

What is your suggested solution

The overlay menu should not push the other leaflet controls down, instead it should open in-place. In addition to it, the size of the menu toggle should be same as of the other icons

Screenshots

Screenshot (6) Screenshot (7)

suyashvsingh commented 1 year ago

I would certainly like to work on this issue

Thanks

nilsnolde commented 1 year ago

The overlay menu should not push the other leaflet controls down

Why not?

suyashvsingh commented 1 year ago

In my opinion, there is one major issue with the current implementation; If a user accidentally hovers, the menu opens, and on mouse leave, the menu closes. This is not the best experience, since all the components go up and down within a second. If the overlay menu is open in place, it would be far less distracting. This is the issue I faced when I was going through the App for the first time.

Suppose the current behaviour is the expected behaviour, then the overlay menu should open when the user clicks on it rather than hover because the user knows exactly what he/she is trying to achieve.

Regarding the size of the toggle, it should be the same as that of the other leaflet controls below it.

Any suggestion regarding the same would be highly appreciated.

Thanks