search

gis-ops / valhalla-app

This is the demo web app running on https://valhalla.openstreetmap.de
https://valhalla.openstreetmap.de
MIT License
157 stars 87 forks source link

Route shown even if waypoint input is altered #144

Closed Ananya2001-an closed 1 year ago

Ananya2001-an commented 1 year ago

Description

What is the problem you are facing

Right now when we change the input of any waypoint, the route is still shown.

What is your suggested solution

Any change made to input should remove the route automatically just as what happens when we click the cross icon to remove the waypoint manually.

Screenshots

https://user-images.githubusercontent.com/55504616/227126913-7ffca138-cc71-45cc-a84b-65fffc6f6dd3.MOV

nilsnolde commented 1 year ago

Yeah that's true. I felt like maybe that's a little disturbing to remove the route on every change, but it's what Google Maps does as well. Obviously I don't like GM, but they did spend millions on UX, so let's trust that:)

Sheikh-JamirAlam commented 1 year ago

Can I work on this?

Ananya2001-an commented 1 year ago

Yeah sure! Wait for one of the maintainers to come and assign this to you.

Sheikh-JamirAlam commented 1 year ago

@Ananya2001-an Can you check the pr? I mean that's how you wanted it to work right?

Ananya2001-an commented 1 year ago

@Ananya2001-an Can you check the pr? I mean that's how you wanted it to work right?

Sure I will review it.