search

gis-ops / valhalla-app

This is the demo web app running on https://valhalla.openstreetmap.de
https://valhalla.openstreetmap.de
MIT License
157 stars 87 forks source link

Height-graph width reduced #149

Closed MihirKp25 closed 1 year ago

MihirKp25 commented 1 year ago

🛠️ Fixes Issue

Closes #136

👨‍💻 Changes proposed

I have reduced the width of height graph from 0.9 to 0.75 in Map.jsx file. I tried to change this width dynamically but it didn't end well. But still it looks pretty nice to me and now we can easily see y axis of height graph.

📄 Note to reviewers

If you find a way of reducing the width dynamically whenever the direction tab closes please tell me :)

📷 Screenshots

image9

chrstnbwnkl commented 1 year ago

@MihirKp25 could you please resolve existing conflicts so we can have a look at your PR?

MihirKp25 commented 1 year ago

I have resolved conflicts. Sorry for inconvenience.

MihirKp25 commented 1 year ago

I have made your suggested changes @nilsnolde

MihirKp25 commented 1 year ago

I will try to make your suggested changes asap.

MihirKp25 commented 1 year ago

https://user-images.githubusercontent.com/106189515/228266030-2a3a20f3-1b56-4483-8306-d7d920438363.mp4


@chrstnbwnkl I have made changes in the function such that the width of the height graph container reduces as the button is clicked. But it seems svg does not have automatic fit content like HTML tags. Can you help me with this error? I have actually used the query selector method to change the width of the container.

chrstnbwnkl commented 1 year ago

@MihirKp25 can you push your latest changes? The functionality in the video looks pretty close to what we want to achieve, right?

MihirKp25 commented 1 year ago

Changes are pushed @chrstnbwnkl . Also, I want to contact you for review of my GSOC proposal. Can you tell me how can I do this

nilsnolde commented 1 year ago

This looks pretty good, thanks @MihirKp25 !

You can find more info on the proposal here: https://wiki.openstreetmap.org/wiki/Google_Summer_of_Code/2023 and here: https://github.com/gis-ops/valhalla-app/issues/67. If you follow those guidelines you should be good. We have (un)fortunately too many applicants to do extensive proposal review. I suggest you upload it to GSoC, we'll surely read and consider it.