search

gis-ops / valhalla-app

This is the demo web app running on https://valhalla.openstreetmap.de
https://valhalla.openstreetmap.de
MIT License
163 stars 90 forks source link

Fix route shown even if input is altered #152

Closed Sheikh-JamirAlam closed 1 year ago

Sheikh-JamirAlam commented 1 year ago

🛠️ Fixes Issue

Fixes #144

👨‍💻 Changes proposed

Now we can alter the waypoint input field and the route will disappear.

📄 Note to reviewers

Please see the attached video.

📷 Screenshots

https://user-images.githubusercontent.com/48979376/227571796-9e8fa0de-408b-48f4-95f9-5c68375e7abe.mp4

Sheikh-JamirAlam commented 1 year ago

@Ananya2001-an Sorry I think I don't get it. What do you mean by altering a waypoint's input value? Do you mean like when the input field becomes completely empty?

Ananya2001-an commented 1 year ago

@Ananya2001-an Sorry I think I don't get it. What do you mean by altering a waypoint's input value?

In the screenshot in issue #144 I showed that once we start changing the input value of a waypoint the marker disappears but the route is still there. So what we want is to remove it if after drawing a route someone starts changing the input (waypoint). But your code is not letting routes getting drawn on the map at all. It will just clear up every time someone types into the search box. Hope u get it now. Please play with the code a bit to understand which code is affecting which part of the app.

Sheikh-JamirAlam commented 1 year ago

@Ananya2001-an Ok so let's say I wanna add another waypoint, I have to type in the search field that time the route gets removed, we don't want that right? Only after the route is drawn, when we try to change the input of any existing waypoint the route will be removed. Am I right?

Ananya2001-an commented 1 year ago

@Ananya2001-an Ok so let's say I wanna add another waypoint, I have to type in the search field that time the route gets removed, we don't want that right? Only after the route is drawn, when we try to change the input of any existing waypoint the route will be removed. Am I right?

Yesss, you are right 👍🏼

Sheikh-JamirAlam commented 1 year ago

@Ananya2001-an Sorry for the late response, I think I have managed to fix it. Am sharing the video and commint my changed now. Also I created a function and named it isWaypoint, hope the naming is fine.

https://user-images.githubusercontent.com/48979376/227718462-08836a77-84ab-4e46-b1ac-0df51fc369bd.mp4

Ananya2001-an commented 1 year ago

@Ananya2001-an Sorry for the late response, I think I have managed to fix it. Am sharing the video and commint my changed now. Also I created a function and named it isWaypoint, hope the naming is fine.

Don't stress about it. It's not a simple issue. Try to work according to your pace. You are already doing good 👍🏼