fixes Inconsistent height graph coloring #57

gis-ops / valhalla-app

This is the demo web app running on https://valhalla.openstreetmap.de

https://valhalla.openstreetmap.de

MIT License

163 stars 90 forks source link

fixes Inconsistent height graph coloring #57 #153

Closed Binabh closed 1 year ago

Binabh commented 1 year ago

🛠️ Fixes Issue

Closes #57

👨‍💻 Changes proposed

new approach in building the geojson so that the inconsistency in coloring in height graph is removed

📄 Note to reviewers

Please let me know if any changes/improvements required

📷 Screenshots

checked on this case

Binabh commented 1 year ago

sure @nilsnolde I will try to explain the best I can and best I have understood. I will be adding commit with comments in few hours. Thank You for your suggestion and review !

Binabh commented 1 year ago

@nilsnolde I have tried to add some explanation. I have to admit that documentation is not my strong part. I will further explain any particular line if required.

Also, one major difference between previous and current code is that previously we were making new linestrings if current heightClass is different than previous but what we actually needed to do is end current linestring and start a new one as soon as we see change in height class. Hope this makes sense.

Binabh commented 1 year ago

Sure, @nilsnolde thank you for your suggestion. Also thank you for the review/merge and this awesome project.