search

gis-ops / valhalla-app

This is the demo web app running on https://valhalla.openstreetmap.de
https://valhalla.openstreetmap.de
MIT License
157 stars 87 forks source link

weather forcast feature #155

Closed Akshat171 closed 1 year ago

Akshat171 commented 1 year ago

🛠️ Fixes Issue

integrating a weather forecast feature.

https://github.com/gis-ops/valhalla-app/issues/138#issue-1630809203

👨‍💻 Changes proposed

Now we can see the weather forecast and can add some value to this application

📄 Note to reviewers

PFA (video) below

📷 Screenshots

https://user-images.githubusercontent.com/81281246/227740008-e9c5512f-954b-44e8-a379-c45d4c6cd7ce.mp4

nilsnolde commented 1 year ago

Maybe I should've been more explicit in https://github.com/gis-ops/valhalla-app/issues/138#issuecomment-1475212635. IMO it's not very useful. I think it's easy enough to open another browser window or look on the phone's weather app. Also, this is a third-party service which requires an API key (probably commercial service with a freemium API key right?). You hard-coded that into the source code of a OSS repo, everyone can see and use that now, I hope you didn't attach your credit card;)

All in all, sorry, but it's not for us.