gis-ops / valhalla-app

This is the demo web app running on https://valhalla.openstreetmap.de
https://valhalla.openstreetmap.de
MIT License
157 stars 87 forks source link

Costing Option Display #161

Closed hs7898753 closed 1 year ago

hs7898753 commented 1 year ago

🛠️ Fixes Issue

Closes #147

👨‍💻 Changes proposed

I suggest showing only the general settings by default and moving the extra settings into a dropdown menu. This will allow users to easily access the settings they need, without being overwhelmed by too much information at once.

📄 Note to reviewers

📷 Screenshots

https://user-images.githubusercontent.com/112114562/228326988-10db5986-75ac-4d8d-b796-b180192ff34b.mp4

MuneebAhmed25211 commented 1 year ago

Hi, hope you are doing well. As far as the issue is concerned, I think there should be 2 different dropdowns, One will be for the general settings in which the first half of the list will be present and in the 2nd dropdown, there will be the extra settings option which will contain the other half. This will clean the settings menu a little bit. Regards, Muneeb

hs7898753 commented 1 year ago

Thankyou @MuneebAhmed25211 for your suggestions. But IMO having two drop down might also lead to confusion if some settings are present in both dropdowns.

MuneebAhmed25211 commented 1 year ago

Ok @hs7898753 I have another idea If we distribute the settings into different dropdowns under the settings dropdown e.g. I see there are 3 options of length, width and height in the extra settings options. If we combine these 3 into a single dropdown (e.g. dimensions) in the extra settings menu, it will take less space and will be clean. If we choose the names of the dropdowns properly and will make the pairs properly (like length, width, height). I suppose it will make no confusion according to me. Hope you understand.

hs7898753 commented 1 year ago

Yah! We can do it. thank you

nilsnolde commented 1 year ago

If we combine these 3 into a single dropdown (e.g. dimensions) in the extra settings menu, it will take less space and will be clean.

Yeah I like that idea! It's true, there's so much space wasted actually. Probably we'll need to even get rid of "General" & "Extra" settings and just provide one settings which is unique for the selected mode. Grouping them like that was mostly due to not repeating code that much. But that really made the code much more confusing and spaghetti, maybe it's better to have the settings for each mode cleanly separated in the code as well at the expense of duplicating the same options a few times.

Then it needs a "careful" grouping of costing options which makes sense. The ones you mentioned make sense. There could also be one for e.g. "road classes" which groups use_highways/living_streets/tracks etc. That'd slim down the UI immensely if grouped right.

Good suggestion, thanks!

hs7898753 commented 1 year ago

Yah! I agree with the suggestion. @nilsnolde What else I think is how is that if we have a icons for the different grouped settings. I think it will look good What you suggest?

nilsnolde commented 1 year ago

If there are good icons for what the groups, sure.. I'd say one after the other, and first have a good outline of the grouping

If we go that way, it's a bigger job and more suitable for the GSoC project, rather than now. It fits into the whole re-write we plan to do. I'll transfer the idea to the appropriate issue.