search

gis-ops / valhalla-app

This is the demo web app running on https://valhalla.openstreetmap.de
https://valhalla.openstreetmap.de
MIT License
154 stars 87 forks source link

Update Maneuvers Display #168

Open hs7898753 opened 1 year ago

hs7898753 commented 1 year ago

Description

What is the problem you are facing

Currently, when more than 2 destinations are entered , the maneuvers section displays all maneuvers continuously from the starting location to the final destination, without separating them by each segment of the route. This can make it difficult for users to understand the maneuvers required for each journey segment.

What is your suggested solution

The maneuvers section should display the maneuvers for each segment of the route separately.

Screenshots

No response

Akshat171 commented 1 year ago

Hey @hs7898753, can you assign this issue to me?

hs7898753 commented 1 year ago

Go on with the issue. @nilsnolde will assign you

Akshat171 commented 1 year ago

can you elaborate on it more? please correct me if I am getting it wrong, your main goal is that you want to divide each part into segments and show it on UI.

nilsnolde commented 1 year ago

Are you asking for GSoC @Akshat171 ? We're closed there, see https://github.com/gis-ops/valhalla-app/issues/67#issuecomment-1493724697

If you generally want to contribute, we can elaborate a bit more.

Akshat171 commented 1 year ago

oh, it's closed. It's okay I will generally contribute.

nilsnolde commented 1 year ago

Ok cool, welcome then :)

Actually I just wanted to elaborate a bit more, but then I found that we're requesting with via locations for intermediate locations: https://github.com/gis-ops/valhalla-app/blob/1d74652e2e62b7d5a748e327484e403a532d8e12/src/utils/valhalla.js#L104. That doesn't generate any legs on a route when there's intermediate waypoints, see https://valhalla.github.io/valhalla/api/turn-by-turn/api-reference/#locations.

Eventually we should let the user choose what type he/she prefers on intermediate locations. There's also a ton more options for Valhalla locations we're not taking advantage of yet.

So, in summary, as of now, this issue is a non-issue, as it's not implement yet what the OP suggests.