Fix error when displaying heightgraph without waypoints

gis-ops / valhalla-app

This is the demo web app running on https://valhalla.openstreetmap.de

https://valhalla.openstreetmap.de

MIT License

154 stars 87 forks source link

Fix error when displaying heightgraph without waypoints #169

Closed Sheikh-JamirAlam closed 1 year ago

Sheikh-JamirAlam commented 1 year ago

🛠️ Fixes Issue

Fixes #166

👨‍💻 Changes proposed

Added warning notification when trying to display heightgraph without any waypoints selected.
No errors when adding DrawText

📄 Note to reviewers

Please take a look at the screenshots in the comments as well.

📷 Screenshots

https://user-images.githubusercontent.com/48979376/229411999-f67a7fe3-daf9-4c54-88ea-638d8b6ea0fb.mp4

Sheikh-JamirAlam commented 1 year ago

📷 Screenshots

https://user-images.githubusercontent.com/48979376/229490579-a5536ffa-75b0-47b2-aa9a-35f99451789c.mp4

Sheikh-JamirAlam commented 1 year ago

@nilsnolde Can you review this please?

nilsnolde commented 1 year ago

Can we either first move entirely to react-toastify or revert the relevant changes here and use the old package?

nilsnolde commented 1 year ago

Other than that, I think that looks fine!

Sheikh-JamirAlam commented 1 year ago

@nilsnolde Does this look good? Shall I commit the changes?

https://user-images.githubusercontent.com/48979376/229614804-4f110c6d-7034-42a8-aa2d-210570ff2773.mp4

nilsnolde commented 1 year ago

Yeah I think that's fine for now thanks. Would you mind raising a first PR removing the old dependency and adding the new one including the changes necessary on master? After merging that, we can do the height graph fix here?

Sheikh-JamirAlam commented 1 year ago

@nilsnolde Alright sure!