search

gis-ops / valhalla-app

This is the demo web app running on https://valhalla.openstreetmap.de
https://valhalla.openstreetmap.de
MIT License
154 stars 87 forks source link

Height-graph bug #170

Open MihirKp25 opened 1 year ago

MihirKp25 commented 1 year ago

Description

What is the problem you are facing

Sometimes when the height graph is open and we try to press some buttons it suddenly breaks and the height graph is closed.

What is your suggested solution

I think the problem arises due to re rendering of map.jsx on every update thus creating this error

Screenshots

https://user-images.githubusercontent.com/106189515/229576052-902f30d1-a361-4e61-b56a-9cd4ced68cb4.mp4

Sheikh-JamirAlam commented 1 year ago

Can I take this issue?

inceptionabhishek commented 1 year ago

well, imo this is not a bug ':)

nilsnolde commented 1 year ago

yeah I agree, it's not a bug. at most a minor inconvenience.

MihirKp25 commented 1 year ago

At first I also thought to be a minor inconvenience but I raised issue just to make sure it works perfectly:)