search

gis-ops / valhalla-app

This is the demo web app running on https://valhalla.openstreetmap.de
https://valhalla.openstreetmap.de
MIT License
153 stars 87 forks source link

Invalid size props are passed #172

Closed rohan-kulkarni-25 closed 1 year ago

rohan-kulkarni-25 commented 1 year ago

Description

What is the problem you are facing

When I deployed the project on my local system and was doing some random changes I noticed that in the console a warning is shown.

Screenshot from 2023-04-04 15-36-55

I just went through the code and found it in Waypoint. jsx size props are directly passed as 32px This was the reason for the warning.

What is your suggested solution

As we are following the proper syntax of tiny and small we should use the same variables here. I have made the changes to check if is this only the reason for the error.

Screenshot from 2023-04-04 15-44-14

And yes the errors were gone. I hope this will help to maintain our code consistency, I am also submitting my proposal under this project in gsoc. Would love to make more such changes which will help us to maintain code consistency and improve our web app UI.

Thanks

Screenshots

No response

nilsnolde commented 1 year ago

Thanks for this. GSoC is finished though, sorry. I mean you can apply still, but it's been too many good applicants already to be considered at this point.

rohan-kulkarni-25 commented 1 year ago

Thanks for this. GSoC is finished though, sorry. I mean you can apply still, but it's been too many good applicants already to be considered at this point.

Ahh, no worries. Would love to apply still as I am interested to contribute on this project.