search

gis-ops / valhalla-app

This is the demo web app running on https://valhalla.openstreetmap.de
https://valhalla.openstreetmap.de
MIT License
164 stars 90 forks source link

Fix double call to route API on truck profile #188

Closed jthiard closed 1 year ago

jthiard commented 1 year ago

Hi, thanks for this very useful Valhalla web frontend!

👨‍💻 Changes proposed

I noticed duplicate calls to route API from / to the truck profile. I guessed this only happens with the truck profile because it is the only one one having a different set of default settings.

📄 Note to reviewers

I'm not familiar with all the effects / actions in this codebase, so I'm not sure this is the right change, but it fix the issue.

📷 Screenshots

Relevant screenshot from https://valhalla.openstreetmap.de/ The first API call is made with the car profile. I then switched to the truck profile, and two API calls were fired at same time, one of them getting a 429 error (too many requests).

Screenshot_2023-06-09_11-42-46

nilsnolde commented 1 year ago

hmpf, smth changed in our secrets or so.. no time right now, but this looks good. thanks!