search

gis-ops / valhalla-app

This is the demo web app running on https://valhalla.openstreetmap.de
https://valhalla.openstreetmap.de
MIT License
164 stars 90 forks source link

Improve isochrones #213

Closed chrstnbwnkl closed 7 months ago

chrstnbwnkl commented 7 months ago

Added denoise and generalize settings for isochrones, added a isochrone location layer for the snapped locations, and prepared for upcoming multipolygon support (without breaking current polygons, at least not more than it was doing anyway :sweat_smile: denoise was not set at all, so any rings are pretty much ignored anyway currently).

gisops-bot commented 7 months ago

Preview is ready! 🚀 You can view it here: https://valhalla-app-tests.gis-ops.com/213

chrstnbwnkl commented 7 months ago

image

Sweet, looks like Leaflet is very lenient when it comes to rendering polygon rings :smile:

nilsnolde commented 7 months ago

Huh, did you change smth in the secrets? Previously there was a very obnoxious error where it couldn't read the secret for some reason and I've not been able to fix that in a medium-effort attempt. I supposed it was a Github bug, awesome that it works again!

EDIT: talking about the preview;)

nilsnolde commented 7 months ago

Only thing I'd change is the location of the parameters. I think that's smth that deserves to live in the main isochrone interface on the left side. It's very very sensitive, 0.1 removes all of those holes you have up there. What do you think?

Anyways, thanks for the effort already, I hope people will appreciate it too. Now isochrones have MUCH better support.

nilsnolde commented 7 months ago

Nit (only if it's not a bunch of work): image

Ah, that's probably this?

added a isochrone location layer for the snapped locations,

chrstnbwnkl commented 7 months ago

No changes in the env, not sure why how or how that issue got resolved :smile:

Denoise and generalize are now part of the main settings. So much boiler code though... at least they're URL synced now!